Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry channel spec update in conformance tests #3971

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Retry channel spec update in conformance tests #3971

merged 1 commit into from
Aug 31, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 31, 2020

Fixes #3959

Proposed Changes

  • Retry channel update in channel spec conformance tests

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 31, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 31, 2020
@aliok aliok mentioned this pull request Aug 31, 2020
Closed
pierDipi
pierDipi approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @vaikas

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@vaikas
Copy link
Contributor

vaikas commented Aug 31, 2020

Great, thanks!
/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@knative-prow-robot knative-prow-robot merged commit 2f233b5 into knative:master Aug 31, 2020
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
@aliok aliok deleted the fix-channel-spec-test-with-retry branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yt3liu yt3liu Awaiting requested review from yt3liu

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestChannelSpec/InMemoryChannel-messaging.knative.dev/v1beta1 flake, when trying to update subscribers.
5 participants
@aliok @vaikas @knative-prow-robot @pierDipi @googlebot