Reject negative Retry config

[pierDipi]

A user can specify a negative number of retries without getting any
validation error. This PR adds a check to validate that
deliverySpec.retry is a non negative integer.

Proposed Changes

• Reject negative Retry config

Release Note

- 🧽 Update or clean up current behavior
DeliverySpec validation rejects a negative retry config.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/duck/v1/delivery_types.go	92.3%	93.3%	1.0
pkg/apis/duck/v1beta1/delivery_types.go	92.3%	93.3%	1.0

[pierDipi]

Ref: #4165

http: TLS handshake error from 10.24.1.1:44280: server key missing

/retest

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-upgrade-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-upgrade-tests:

.Test

[pierDipi]

Ref: #4165

http: TLS handshake error from 10.24.1.1:44280: server key missing

/retest

[lionelvillard]

@pierDipi #4165 has been merged. Are you suggesting it didn't fix the infinite webhook crash loop?

/cc @ian-mi

[pierDipi]

It hasn't been backported to 0.18, so the upgrade test fails when it installs eventing from the latest public release.

[pierDipi]

From logs here: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/4216/pull-knative-eventing-upgrade-tests/1313122358009008128#1:build-log.txt%3A137, I see:

=====>>=======================================================
==== >> INSTALLING KNATIVE EVENTING LATEST PUBLIC RELEASE ====
=====>>=======================================================
==== Mon Oct  5 07:26:32 PDT 2020
=====>>=======================================================
// ...
namespace/knative-eventing created
// ...
Waiting until all pods in namespace knative-eventing-wvozzrkvkv are up......................................................................................................................................................
ERROR: timeout waiting for pods to come up
eventing-controller-6fc9c6cfc4-4kfsn    1/1   Running            0     5m18s
eventing-controller-6fc9c6cfc4-qk6h8    1/1   Running            0     5m18s
eventing-controller-6fc9c6cfc4-sh9fc    1/1   Running            0     5m18s
eventing-webhook-667c8f6dc4-gvsqj       0/1   CrashLoopBackOff   5     5m23s
eventing-webhook-667c8f6dc4-mrpfr       0/1   CrashLoopBackOff   5     5m23s
eventing-webhook-667c8f6dc4-pwdfk       0/1   CrashLoopBackOff   5     5m23s
imc-controller-6c4f87765c-7r242         1/1   Running            0     5m30s
imc-dispatcher-74dcf4647f-gnwlg         1/1   Running            0     5m29s
mt-broker-controller-6d789b944d-f4cd2   1/1   Running            0     5m31s
mt-broker-filter-6bbcc67bc5-bqb7b       1/1   Running            0     5m31s
mt-broker-ingress-64987f6f4-fhszq       1/1   Running            0     5m31s

// Failed pod logs
{"level":"info","ts":"2020-10-05T14:30:58.272Z","logger":"eventing-webhook","caller":"webhook/webhook.go:226","msg":"Starting to fail readiness probes...","commit":"74b9bed","knative.dev/pod":"eventing-webhook-667c8f6dc4-gvsqj"}
{"level":"info","ts":"2020-10-05T14:30:58.273Z","logger":"eventing-webhook.sinkbindings.webhook.sources.knative.dev","caller":"controller/controller.go:458","msg":"Shutting down workers","commit":"74b9bed","knative.dev/pod":"eventing-webhook-667c8f6dc4-gvsqj"}
2020/10/05 14:30:58 http: TLS handshake error from 10.24.0.1:40222: server key missing

[lionelvillard]

/lgtm