-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test eventing on KinD 1.17-1.19 #4273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4273 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 287 287
Lines 7889 7889
=======================================
Hits 6332 6332
Misses 1174 1174
Partials 383 383 Continue to review full report at Codecov.
|
6c53430
to
36a95a8
Compare
/retest I couldn't have broken that :-/ |
8a4b065
to
550eefa
Compare
Thanks! Really awesome. Looks like these are coming from prow?
|
This also adds coverage for non-standard cluster DNS suffixes (a la `.svc.cluster.local`)
@vaikas I have some logic we might want to pick up for this downstream in mink, but I'd rather land this and follow-up? I've rebased, so this should be good-to-go. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
Run Eventing e2e on Github Actions with KinD to get coverage of supported version range: 1.17 - 1.19
TODO: It might be worth parallelizing on
-channel
and-source
, if those make sense as dimensions to test in parallel to speed things up.Release Note
Docs
N/A