Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test eventing on KinD 1.17-1.19 #4273

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

mattmoor
Copy link
Member

Proposed Changes

Run Eventing e2e on Github Actions with KinD to get coverage of supported version range: 1.17 - 1.19

TODO: It might be worth parallelizing on -channel and -source, if those make sense as dimensions to test in parallel to speed things up.

  • 🎁 Add new feature

Release Note

Eventing now tests the supported Kubernetes version range pre-submit.

Docs

N/A

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 10, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2020
@mattmoor
Copy link
Member Author

cc @vaikas @n3wscott

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #4273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4273   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files         287      287           
  Lines        7889     7889           
=======================================
  Hits         6332     6332           
  Misses       1174     1174           
  Partials      383      383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef177f...85c8a37. Read the comment docs.

@mattmoor mattmoor force-pushed the kind-e2e branch 2 times, most recently from 6c53430 to 36a95a8 Compare October 10, 2020 22:16
@mattmoor
Copy link
Member Author

/retest

I couldn't have broken that :-/

@mattmoor mattmoor force-pushed the kind-e2e branch 4 times, most recently from 8a4b065 to 550eefa Compare October 11, 2020 15:02
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Oct 11, 2020
@vaikas
Copy link
Contributor

vaikas commented Oct 12, 2020

Thanks! Really awesome. Looks like these are coming from prow?

2020/10/11 15:29:03 Env variable ARTIFACTS not set. Using artifacts instead.
2020/10/11 15:29:13 Env variable ARTIFACTS not set. Using artifacts instead.
2020/10/11 15:29:18 Env variable ARTIFACTS not set. Using artifacts instead.
2020/10/11 15:29:33 Env variable ARTIFACTS not set. Using artifacts instead.

This also adds coverage for non-standard cluster DNS suffixes (a la `.svc.cluster.local`)
@mattmoor
Copy link
Member Author

@vaikas I have some logic we might want to pick up for this downstream in mink, but I'd rather land this and follow-up?

I've rebased, so this should be good-to-go.

@vaikas
Copy link
Contributor

vaikas commented Oct 12, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3eafdc9 into knative:master Oct 12, 2020
@mattmoor mattmoor deleted the kind-e2e branch October 12, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants