config-br-defaults set delivery spec defaults #4328

runzexia · 2020-10-15T07:08:57Z

Signed-off-by: runzexia root@junwuhui.cn

Proposed Changes

🎁 Add new feature

Release Note

config-br-defaults support setting delivery spec defaults

Docs

knative-prow-robot · 2020-10-15T07:09:11Z

Hi @runzexia. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

runzexia · 2020-10-15T07:12:18Z

pkg/apis/config/defaults.go

 	*duckv1.KReference `json:",inline"`
+	Delivery           *eventingduckv1.DeliverySpec `json:"delivery,omitempty"`


I have questions about this place.
If I use v1Delivery, I need to convert v1Delivery to v1beta1Delivery.

codecov · 2020-10-15T09:38:49Z

Codecov Report

Merging #4328 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4328      +/-   ##
==========================================
+ Coverage   80.73%   80.79%   +0.05%     
==========================================
  Files         287      287              
  Lines        7870     7877       +7     
==========================================
+ Hits         6354     6364      +10     
+ Misses       1135     1132       -3     
  Partials      381      381

Impacted Files	Coverage Δ
pkg/apis/config/defaults.go	`85.71% <100.00%> (ø)`
pkg/apis/eventing/v1/broker_defaults.go	`100.00% <100.00%> (ø)`
pkg/apis/eventing/v1beta1/broker_defaults.go	`100.00% <100.00%> (ø)`
pkg/tracing/attributes.go	`100.00% <0.00%> (+50.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8212a8...1e1b99a. Read the comment docs.

Signed-off-by: RyderXia <ryder.xia@sap.com>

vaikas

Thanks so much!

pkg/apis/config/defaults.go

vaikas · 2020-10-16T09:05:48Z

/ok-to-test

Signed-off-by: runzexi <root@junwuhui.cn>

vaikas

Thanks!

pkg/apis/config/defaults.go

Signed-off-by: runzexi <root@junwuhui.cn>

vaikas · 2020-10-19T07:09:43Z

/lgtm
/approve

knative-prow-robot · 2020-10-19T07:09:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runzexia, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi

@runzexia We should document this feature, would you mind opening an issue in docs?

runzexia · 2020-10-19T14:03:17Z

@pierDipi created issue knative/docs#2944 😊

pierDipi · 2020-10-19T14:07:26Z

Thank you!

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2020

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 15, 2020

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2020

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2020

knative-prow-robot requested review from lionelvillard and matzew October 15, 2020 07:09

runzexia commented Oct 15, 2020

View reviewed changes

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2020

runzexia changed the title ~~[WIP] config-br-defaults should setting delivery spec defaults~~ [WIP] config-br-defaults set delivery spec defaults Oct 15, 2020

runzexia force-pushed the config-br-defaults-support-setting-delivery- branch from 8100086 to 9aba2db Compare October 15, 2020 13:05

knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Oct 15, 2020

runzexia force-pushed the config-br-defaults-support-setting-delivery- branch from 9aba2db to 545b4cc Compare October 15, 2020 13:10

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 15, 2020

config-br-defaults set delivery spec defaults

55f7b84

Signed-off-by: RyderXia <ryder.xia@sap.com>

runzexia force-pushed the config-br-defaults-support-setting-delivery- branch from 545b4cc to 55f7b84 Compare October 15, 2020 13:14

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2020

runzexia changed the title ~~[WIP] config-br-defaults set delivery spec defaults~~ config-br-defaults set delivery spec defaults Oct 15, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2020

vaikas reviewed Oct 16, 2020

View reviewed changes

pkg/apis/config/defaults.go Outdated Show resolved Hide resolved

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2020

use eventingv1 deliveryspec

c062985

Signed-off-by: runzexi <root@junwuhui.cn>

vaikas reviewed Oct 16, 2020

View reviewed changes

pkg/apis/config/defaults.go Outdated Show resolved Hide resolved

eventingduckv1

1e1b99a

Signed-off-by: runzexi <root@junwuhui.cn>

knative-prow-robot assigned vaikas Oct 19, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2020

knative-prow-robot merged commit e9a5f00 into knative:master Oct 19, 2020

runzexia deleted the config-br-defaults-support-setting-delivery- branch October 19, 2020 08:47

pierDipi reviewed Oct 19, 2020

View reviewed changes

runzexia mentioned this pull request Oct 19, 2020

eventing config-br-defaults set delivery spec defaults knative/docs#2944

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config-br-defaults set delivery spec defaults #4328

config-br-defaults set delivery spec defaults #4328

runzexia commented Oct 15, 2020 •

edited

Loading

knative-prow-robot commented Oct 15, 2020

runzexia Oct 15, 2020 •

edited

Loading

codecov bot commented Oct 15, 2020 •

edited

Loading

vaikas left a comment

vaikas commented Oct 16, 2020

vaikas left a comment

vaikas commented Oct 19, 2020

knative-prow-robot commented Oct 19, 2020

pierDipi left a comment

runzexia commented Oct 19, 2020

pierDipi commented Oct 19, 2020

		*duckv1.KReference `json:",inline"`
		Delivery *eventingduckv1.DeliverySpec `json:"delivery,omitempty"`

config-br-defaults set delivery spec defaults #4328

config-br-defaults set delivery spec defaults #4328

Conversation

runzexia commented Oct 15, 2020 • edited Loading

Proposed Changes

knative-prow-robot commented Oct 15, 2020

runzexia Oct 15, 2020 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 15, 2020 • edited Loading

Codecov Report

vaikas left a comment

Choose a reason for hiding this comment

vaikas commented Oct 16, 2020

vaikas left a comment

Choose a reason for hiding this comment

vaikas commented Oct 19, 2020

knative-prow-robot commented Oct 19, 2020

pierDipi left a comment

Choose a reason for hiding this comment

runzexia commented Oct 19, 2020

pierDipi commented Oct 19, 2020

runzexia commented Oct 15, 2020 •

edited

Loading

runzexia Oct 15, 2020 •

edited

Loading

codecov bot commented Oct 15, 2020 •

edited

Loading