Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.18] Readyness probe in broker ingress #4483

Merged
merged 2 commits into from
Nov 6, 2020
Merged

[0.18] Readyness probe in broker ingress #4483

merged 2 commits into from
Nov 6, 2020

Conversation

slinkydeveloper
Copy link
Contributor

Fixes #4473

Proposed Changes

  • Start readiness probe in code
  • Yaml stuff

@slinkydeveloper
Fix knative#4473
bb8bac1 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 6, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2020
@slinkydeveloper
Copy link
Contributor Author

/retest

@slinkydeveloper
Massage the filter yaml
8c47458 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2020
@zhongduo
Copy link
Contributor

zhongduo commented Nov 6, 2020 •
edited
Loading 

go: downloading github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578
go: downloading github.com/jmespath/go-jmespath v0.3.0
knative.dev/sample-source/pkg/reconciler imports
	knative.dev/eventing/pkg/apis/sources/v1: module knative.dev/eventing@latest found (v0.0.0-00010101000000-000000000000, replaced by /home/runner/work/eventing/eventing/src/knative.dev/eventing), but does not contain package knative.dev/eventing/pkg/apis/sources/v1
Error: Process completed with exit code 1.

I don't think the downstream is relevant.

@zhongduo
Copy link
Contributor

zhongduo commented Nov 6, 2020

/assign

@zhongduo
Copy link
Contributor

zhongduo commented Nov 6, 2020

/lgtm
/hold please unhold if you don't want to wait for a second opinion.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 6, 2020
matzew
matzew approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matzew,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Nov 6, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2020
@knative-prow-robot knative-prow-robot merged commit 911edb6 into knative:release-0.18 Nov 6, 2020
matzew pushed a commit to matzew/eventing that referenced this pull request Nov 7, 2020
@slinkydeveloper @matzew
[0.18] Readyness probe in broker ingress (knative#4483)
92165a5 
* Fix knative#4473

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Massage the filter yaml

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
matzew pushed a commit to openshift/knative-eventing that referenced this pull request Nov 7, 2020
@slinkydeveloper @matzew
[0.18] Readyness probe in broker ingress (knative#4483)
42368d1 
* Fix knative#4473

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Massage the filter yaml

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@matzew matzew mentioned this pull request Nov 7, 2020
Merged
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Nov 7, 2020
@aliok @matzew
@pierDipi @slinkydeveloper @capri-xiyue
Backports and skip tracing (#959)
e5c8a88 
* Update pingsource-mt-adapter.yaml

* Like on 0.18.3, we skip the tracing tests

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* [release-0.18] Retry on network failures (knative#4454) (knative#4457)

* Retry on network failures (knative#4454)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* nethttp -> http

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Backport knative#4465 (knative#4468)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* [0.18] Backport knative#4466 (knative#4471)

* Remove double invocations to responseWriter.WriteHeader in filter handler (knative#4466)

* Fix knative#4464

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Docs

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Moar tests

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Linting

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Nit with metrics

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

(cherry picked from commit a6fc540)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Nit

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fixed wrong marshall in apiserversouece which will fix the missing ceOverrides extension  (knative#4477) (knative#4480)

* fixed wrong marshall

* fixed UT

* [0.18] Readyness probe in broker ingress (knative#4483)

* Fix knative#4473

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Massage the filter yaml

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Co-authored-by: capri-xiyue <52932582+capri-xiyue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@grantr grantr Awaiting requested review from grantr

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@matzew matzew

@zhongduo zhongduo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slinkydeveloper @zhongduo @knative-prow-robot @matzew