Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update maven profile buildEnv in springboot templates #2014

Merged
merged 1 commit into from
Oct 18, 2023
Merged

chore: update maven profile buildEnv in springboot templates #2014

merged 1 commit into from
Oct 18, 2023

Conversation

trisberg
Copy link
Member

@trisberg trisberg commented Oct 10, 2023 •
edited
Loading

  • update the documentation for springboot arm based builds

Changes

  • 🎁 Updated the buildEnv for selecting maven profile
  • 🧹 Updated build docs for arm based systems to use new builder image

/kind enhancement

Fixes #

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Oct 10, 2023

@trisberg: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

  • update the documentation for springboot arm based builds

Changes

  • 🎁 Updated the buildEnv for selecting maven profile
  • 🧹 Updated build docs for arm based systems to use new builder image

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from maximilien and rhuss October 10, 2023 22:41
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2023
@trisberg trisberg changed the title chore: update maven profile buildEnv in springoot templates chore: update maven profile buildEnv in springboot templates Oct 10, 2023
@trisberg trisberg force-pushed the springboot-maven-profile branch from 111b5ac to dafd22d Compare October 10, 2023 22:42
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3641bfe) 61.76% compared to head (469d47a) 62.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
+ Coverage   61.76%   62.74%   +0.97%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8458     8592     +134     
+ Misses       4390     4232     -158     
- Partials      845      869      +24
Flag Coverage Δ
e2e-test 36.46% <ø> (ø)
e2e-test-oncluster 30.44% <ø> (-0.09%) ⬇️
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.50% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.43% <ø> (+2.14%) ⬆️
unit-tests-macos-latest 48.19% <ø> (ø)
unit-tests-ubuntu-latest 48.98% <ø> (ø)
unit-tests-windows-latest 48.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2023
@trisberg trisberg force-pushed the springboot-maven-profile branch from 70a2cc0 to 1f12c9a Compare October 17, 2023 19:01
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@trisberg
Copy link
Member Author

Rebased

@trisberg @matejvasek
chore: update maven profile buildEnv in springboot templates
469d47a 
- Update the documentation for springboot arm based builds

- Add the generated filesystem
@matejvasek matejvasek force-pushed the springboot-maven-profile branch from 1f12c9a to 469d47a Compare October 18, 2023 17:39
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, trisberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 84ad7d7 into knative:main Oct 18, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien Awaiting requested review from maximilien

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trisberg @matejvasek