Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont duplicate subscriptions #2116

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Dont duplicate subscriptions #2116

merged 2 commits into from
Jan 16, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jan 11, 2024

Changes

  • 🧹 Dont duplicate subscriptions

/kind

Fixes #

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 11, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Dont duplicate subscriptions

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2024
@matzew
Copy link
Member Author

matzew commented Jan 11, 2024

/hold
will update tests

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ebaf57) 64.17% compared to head (5cb8484) 64.79%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
+ Coverage   64.17%   64.79%   +0.62%     
==========================================
  Files         108      106       -2     
  Lines       13870    13879       +9     
==========================================
+ Hits         8901     8993      +92     
+ Misses       4100     3988     -112     
- Partials      869      898      +29
Flag Coverage Δ
e2e-test 37.32% <59.09%> (-0.04%) ⬇️
e2e-test-oncluster 30.51% <0.00%> (-0.05%) ⬇️
e2e-test-oncluster-runtime 26.56% <0.00%> (?)
integration-tests 51.85% <100.00%> (+2.04%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
@matzew
We do not want to add duplicated subscriptiosn
b70bf47 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the dont_duplicate_subscriptions branch from ac68eb1 to e9776cc Compare January 15, 2024 06:23
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2024
@matzew
Copy link
Member Author

matzew commented Jan 15, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2024
@matzew
new unit test
5cb8484 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the dont_duplicate_subscriptions branch from e9776cc to 5cb8484 Compare January 15, 2024 06:24
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@knative-prow knative-prow bot merged commit b29f702 into knative:main Jan 16, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @lkingland @knative-prow-robot