feat: host builder nonregular file support

[lkingland]

Changes

• 🎁 Host builder nonregular file support (ex: symlinks)

/kind enhancement

Fixes #

Release Note

The prototype host builder now supports nonregular files such as symlinks

Docs

[knative-prow]

@lkingland: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• 🎁 Host builder nonregular file support (ex: symlinks)

/kind

Fixes #

Release Note

The prototype host builder now supports nonregular files such as symlinks

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (c252c4f) 64.21% compared to head (ed15d98) 65.05%.
Report is 28 commits behind head on main.

❗ Current head ed15d98 differs from pull request most recent head 17c097d. Consider uploading reports for the commit 17c097d to get more accurate results

Files	Patch %	Lines
pkg/oci/containerize.go	23.07%	16 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
+ Coverage   64.21%   65.05%   +0.84%     
==========================================
  Files         108      108              
  Lines       13919    13940      +21     
==========================================
+ Hits         8938     9069     +131     
+ Misses       4108     3968     -140     
- Partials      873      903      +30     

Flag	Coverage Δ
e2e-test	37.31% <0.00%> (-0.06%)	⬇️
e2e-test-oncluster	30.49% <0.00%> (-0.10%)	⬇️
e2e-test-oncluster-runtime	26.78% <0.00%> (?)
e2e-test-runtime-go	25.51% <0.00%> (?)
e2e-test-runtime-node	26.53% <0.00%> (?)
e2e-test-runtime-python	26.53% <0.00%> (?)
e2e-test-runtime-quarkus	26.64% <0.00%> (?)
e2e-test-runtime-rust	25.54% <0.00%> (?)
e2e-test-runtime-springboot	25.67% <0.00%> (?)
e2e-test-runtime-typescript	26.64% <0.00%> (?)
integration-tests	51.77% <23.07%> (+1.95%)	⬆️
unit-tests-macos-latest	48.76% <23.07%> (-0.10%)	⬇️
unit-tests-ubuntu-latest	49.52% <23.07%> (?)
unit-tests-windows-latest	48.83% <23.07%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matejvasek]

Would it be possible to add some test?

[matejvasek]

We already have some complex test here:

func/pkg/oci/builder_test.go

Line 30 in 24fe6d3

func TestBuilder_Build(t *testing.T) {

Please consider adding symlink there.

[matejvasek]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment