make was not called #2234

[matzew]

Changes

• the make seems to be forgotten often, running it after 2234 PR

/kind

Fixes #

Release Note

Docs

[knative-prow]

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• the make seems to be forgotten often, running it after 2234 PR

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matzew]

@lkingland @matejvasek can we make this more intuitive ? Either by a CI linter, or something?

[lkingland]

@lkingland @matejvasek can we make this more intuitive ? Either by a CI linter, or something?

Yes, we can, and we should 👍🏻 A little background:

Make may actually have been called, because the actual root problem that causes this most often (though perhaps not in this PR) is that the task which updates docs is not properly clearing its environment, so if (like me) you have FUNC_ENABLE_HOST_BUILDER=true or anything in your global config which alters command default options, the docs are all updated on make to include those differences. This means I am perpetually confronted with unstaged changes in ./docs, and forget that sometimes the changes are valid and need to be checked in. I presume this happens for others as well.

The ideal fix here is probably twofold: 1) fix the docs generator to clear its environment before generating docs and then 2) have a CI task which (like we do for zz_filesystem_generated) fail in CI if there are unstaged changes in ./docs after building.

[lkingland]

/lgtm

[matejvasek]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment