-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test suite refactor #2289
Draft
lkingland
wants to merge
18
commits into
knative:main
Choose a base branch
from
lkingland:test-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Apr 24, 2024
-
fix: namespace logic cleanup and test isolation
- Pulls logic for defaulting to active namespace (K8S) moved UP to CLI during flag default calculation. - Pushes logic of deciding between f.Namespace vs f.Deploy.Namespace down into implementations. - Updates some tests which needed to have their environment cleared. - Refactors Pipelines tests to use client API. - Removes namespaces as a state variable all structures, instead passing as an argument. - Moves FromTempDirectory to testing package for use outside cmd.
Configuration menu - View commit details
-
Copy full SHA for e28d6ab - Browse repository at this point
Copy the full SHA e28d6abView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9462fe - Browse repository at this point
Copy the full SHA d9462feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66b2125 - Browse repository at this point
Copy the full SHA 66b2125View commit details -
Configuration menu - View commit details
-
Copy full SHA for 352c667 - Browse repository at this point
Copy the full SHA 352c667View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaaeede - Browse repository at this point
Copy the full SHA aaaeedeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11bee53 - Browse repository at this point
Copy the full SHA 11bee53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f06763 - Browse repository at this point
Copy the full SHA 6f06763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6642f80 - Browse repository at this point
Copy the full SHA 6642f80View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b8178ea - Browse repository at this point
Copy the full SHA b8178eaView commit details
Commits on Apr 30, 2024
-
- Utilize the `make check-embedded-fs` target - Renames schema-check to check-schema to match other checks - Delegates runtime and builder matrix logic to test suite impl - Relocates converage reformatting to workflows
Configuration menu - View commit details
-
Copy full SHA for 47f69da - Browse repository at this point
Copy the full SHA 47f69daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 810b98c - Browse repository at this point
Copy the full SHA 810b98cView commit details -
- Adds test-all target - integration and e2e tests clearly state they run unit tests too - integration and e2e tests clear cache - Adds a check-embedded-fs target - Adds several missing .PHONY lines
Configuration menu - View commit details
-
Copy full SHA for 3d254b2 - Browse repository at this point
Copy the full SHA 3d254b2View commit details -
- Default builder and pusher set to embedded Host Builder/Pusher(oci) - Most tests clear environment - Environment defaults can be controlled via environment variables - Tests which require back-compat `git` binary actively check and skip when running with a cleared environment (both integration and unit). - Bugfixes for when run in tandem with E2E tests - Ignores go-created directories in the default home path (testdata)
Configuration menu - View commit details
-
Copy full SHA for a7eb595 - Browse repository at this point
Copy the full SHA a7eb595View commit details -
- Updates docs and moves package doc to a README.md - Sets up MatrixRuntimes and MatrixBuilders as an opt-in filter - Implements delete - Bugfixes when run via make
Configuration menu - View commit details
-
Copy full SHA for c02bb84 - Browse repository at this point
Copy the full SHA c02bb84View commit details
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e82deff - Browse repository at this point
Copy the full SHA e82deffView commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f6ffd41 - Browse repository at this point
Copy the full SHA f6ffd41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43db89f - Browse repository at this point
Copy the full SHA 43db89fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98ea9b6 - Browse repository at this point
Copy the full SHA 98ea9b6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.