Add config to disable auto-creation of domain claims #330
Conversation
knative-prow-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 95.09% 95.30% +0.21%
==========================================
Files 38 37 -1
Lines 815 767 -48
==========================================
- Hits 775 731 -44
+ Misses 29 25 -4
Partials 11 11
Continue to review full report at Codecov.
|
| @@ -116,6 +116,10 @@ const ( | |||
| // constructing the Knative Route's tag names. | |||
| DefaultTagTemplate = "{{.Tag}}-{{.Name}}" | |||
|
|
|||
| // AutocreateClusterDomainClaimsKey is the key for the | |||
| // AutocreateClusterDomainClaims property. | |||
| AutocreateClusterDomainClaimsKey = "autocreateClusterDomainClaims" | |||
There was a problem hiding this comment.
I don't like this name, but I don't have a better suggestion. 🤔
There was a problem hiding this comment.
same :(. If we can come up with something better before we make this "beta", that'd be nice.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Changes
🎁 Adds
autocreateClusterDomainClaimsflag to network configmap.Used to disable automatic claiming of domain names in favour of explicit delegation of domain name ownership to namespaces via the spec.Namespace field of
ClusterDomainClaim(this is important for multi-tenant environments which need to prevent 'squatting' or 'intercepting' domain names used in other namespaces but exposed via the shared ingress)./kind enhancement
Release Note
/assign @mattmoor @tcnghia