Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip non-alpha/beta tests #527

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Allow to skip non-alpha/beta tests #527

merged 1 commit into from
Oct 12, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Oct 7, 2021

The --skip-tests flag was introduced to skip alpha or beta tests
before and it does not allow to skip stable test.

But now, to support gateway-api, we need to skip some stable tests as some
features are not supported even by the upstream.

The `--skip-tests` flag was introduced to skip alpha or beta tests
before and it does not allow to skip stable test.

But now, to support gateway-api, we need to skip some tests as some
funtions are not supported even by the upstream.
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #527 (6ee0324) into main (d5e4386) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          37       37           
  Lines         774      774           
=======================================
  Hits          738      738           
  Misses         25       25           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e4386...6ee0324. Read the comment docs.

@nak3
Copy link
Contributor Author

nak3 commented Oct 11, 2021

/cc @dprotaso @ZhiminXiang @carlisia

This change needs net-gateway-api controller as it cannot pass some tests like knative-extensions/net-gateway-api#20 which is not supported by Gateway API CRD yet.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c6e5f78 into knative:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants