Implement strongly typed class reconcilers #1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1098
Adding a new annotation config to allow us to configure strongly classed reconcilers, such as Eventing's Broker, or Serving's Ingress.
This will be a breaking API change for types that opt into this behavior. The main changes are the addition of
classValue string
toNewImpl
andNewReconciler
(for tests)This feature is enabled with a golang annotation argument:
// +genreconciler:class=example.com/filter.class