Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test TestInformedWatcher #1908

Closed

Conversation

runzexia
Copy link
Contributor

@runzexia runzexia commented Nov 15, 2020

Signed-off-by: runzexia root@junwuhui.cn
ref #1907

Signed-off-by: runzexia <root@junwuhui.cn>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 15, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: runzexia
To complete the pull request process, please assign mdemirhan after the PR has been reviewed.
You can assign the PR to them by writing /assign @mdemirhan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #1908 (2d29075) into master (615f17a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1908   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files         207      207           
  Lines        8739     8739           
=======================================
  Hits         6067     6067           
  Misses       2402     2402           
  Partials      270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615f17a...2d29075. Read the comment docs.

@runzexia runzexia closed this Nov 26, 2020
@runzexia runzexia deleted the flaky-test-TestInformedWatcher branch November 26, 2020 18:43
@dprotaso
Copy link
Member

Oh sorry @runzexia I didn't see this PR - my apologies

@runzexia
Copy link
Contributor Author

no problem😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants