Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format copyright headers to match boilerplate #1962

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Format copyright headers to match boilerplate #1962

merged 1 commit into from
Dec 15, 2020

Conversation

antoineco
Copy link
Contributor

Proposed Changes

  • Run sed on the entire codebase to format copyright headers that diverge from the project's boilerplate

The "Boilerplate Check" GitHub Action reports those drifts on new PRs, but not for files that already existed in the repo before the check was introduced.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 15, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release labels Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #1962 (2228c3a) into master (c35cc6b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   68.92%   68.96%   +0.04%     
==========================================
  Files         209      209              
  Lines        8778     8778              
==========================================
+ Hits         6050     6054       +4     
+ Misses       2453     2451       -2     
+ Partials      275      273       -2     
Impacted Files Coverage Δ
source/source_labels.go 100.00% <ø> (ø)
source/source_stats_reporter.go 85.71% <ø> (ø)
test/upgrade/functions.go 100.00% <ø> (ø)
test/upgrade/steps.go 96.84% <ø> (ø)
test/upgrade/suite_execution.go 92.68% <ø> (ø)
test/upgrade/vars.go 0.00% <ø> (ø)
test/gcs/mock/mock.go 92.47% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35cc6b...2228c3a. Read the comment docs.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@knative-prow-robot knative-prow-robot merged commit af53027 into knative:master Dec 15, 2020
@antoineco antoineco deleted the copyright-header-fmt branch December 15, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants