Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for CVE-2022-28948 #2532

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Add fix for CVE-2022-28948 #2532

merged 1 commit into from
Jun 21, 2022

Conversation

qu1queee
Copy link
Contributor

Changes

/kind cleanup

Fixes

Due to CVE 2022-28948. External users of packages such as knative/net-istio might get flagged by vulnerability scanning tools.

Release Note

Bump gopkg.in/yaml.v3 to address CVE-2022-28948

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 17, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 17, 2022

Hi @qu1queee. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2022
@qu1queee qu1queee force-pushed the qu1queee/fix_cve_2022-28948 branch from 2ac4c7f to a3595e1 Compare June 17, 2022 08:39
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022
@qu1queee
Add fix for CVE-2022-28948
81f533d 
Per go-yaml/yaml#666, the recommendation is
to bump to v3.0.1. I detected this as an indirect dependency that was
flagged in net-istio.
@qu1queee qu1queee force-pushed the qu1queee/fix_cve_2022-28948 branch from a3595e1 to 81f533d Compare June 17, 2022 08:41
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #2532 (81f533d) into main (7d607d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files         163      163           
  Lines        9744     9744           
=======================================
  Hits         7955     7955           
  Misses       1551     1551           
  Partials      238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d607d6...81f533d. Read the comment docs.

@psschwei
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2022
@qu1queee
Copy link
Contributor Author

/retest

psschwei
psschwei reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch update is pretty straightforward.
/lgtm
/assign @dprotaso @evankanderson
(so as to not abuse release lead superpowers)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@knative-prow knative-prow bot merged commit 1f01575 into knative:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@dprotaso dprotaso

@evankanderson evankanderson

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qu1queee @psschwei @dprotaso @evankanderson @knative-prow-robot