Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 #2775

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 28, 2023

Bumps github.com/gorilla/websocket from 1.4.2 to 1.5.0.

Release notes

Sourced from github.com/gorilla/websocket's releases.

Minor new features and maintenance update

CHANGELOG

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 28, 2023
@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from creydr and KauzClay July 28, 2023 13:45
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4866914) 81.82% compared to head (458f35d) 81.82%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         167      167           
  Lines       10201    10201           
=======================================
  Hits         8347     8347           
  Misses       1608     1608           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor

nak3 commented Jul 31, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/gorilla/websocket-1.5.0 branch from 09931f6 to 1fba26e Compare July 31, 2023 14:40
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 31, 2023
@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2023
@dprotaso
Copy link
Member

@nak3 @kvmware do we know why the github actions aren't being triggered?

@jarias-lfx
Copy link

/easycla

@nak3
Copy link
Contributor

nak3 commented Aug 1, 2023

@dependabot recreate

@nak3
Copy link
Contributor

nak3 commented Aug 1, 2023

@nak3 @kvmware do we know why the github actions aren't being triggered?

I have no idea. I have seen this on downstream sometimes. I suspect that github issue...

Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.2 to 1.5.0.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](gorilla/websocket@v1.4.2...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/gorilla/websocket-1.5.0 branch from c4599d4 to 1f7104c Compare August 1, 2023 01:17
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2023
@nak3
Copy link
Contributor

nak3 commented Aug 1, 2023

Closing & re-opening the PR triggered the github action #2774

@nak3 nak3 closed this Aug 1, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 1, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@nak3 nak3 reopened this Aug 1, 2023
@nak3
Copy link
Contributor

nak3 commented Aug 1, 2023

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2023

@kvmware can you open a GitHub support issue for https://github.com/orgs/community/discussions/62346 ?

@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

Created a ticket but it seems to be a personal ticket. Even though I opened it in name of knative

@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

/retest

@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

It looks like the github action was ran https://github.com/knative/pkg/actions/runs/5721737661 but it was skipped.

@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

It seems that actions bot made a commit as well
image

@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

The failure was from a flakey unit test which has passed with retest. This PR just needs LGTM and approval
/approve

@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow knative-prow bot merged commit b3a65a0 into main Aug 2, 2023
43 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/gorilla/websocket-1.5.0 branch August 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants