Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop mako #3060

Merged
merged 4 commits into from
Jun 20, 2024
Merged

drop mako #3060

merged 4 commits into from
Jun 20, 2024

Conversation

dprotaso
Copy link
Member

Fixes: #2820

Copy link

knative-prow bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 20, 2024
@knative-prow knative-prow bot requested review from aslom and mgencur June 20, 2024 15:20
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (b94232c) to head (53c11a7).
Report is 1 commits behind head on main.

Current head 53c11a7 differs from pull request most recent head 71eaabd

Please upload reports for the commit 71eaabd to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   78.59%   78.43%   -0.17%     
==========================================
  Files         191      191              
  Lines        8934     8934              
==========================================
- Hits         7022     7007      -15     
- Misses       1643     1665      +22     
+ Partials      269      262       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/retest

@dprotaso
Copy link
Member Author

Downstream failures are expected until eventing merges their PR

/assign @pierDipi

@pierDipi
Copy link
Member

/retest

@dprotaso
Copy link
Member Author

I'm going to revert the linter changes in this PR and pull it into a separate one

@dprotaso
Copy link
Member Author

/override "style / Golang / Lint"

Copy link

knative-prow bot commented Jun 20, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@knative-prow knative-prow bot merged commit cd0e61e into knative:main Jun 20, 2024
63 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop mako code and dependency
2 participants