Set default value for TimeoutSeconds to be 1

knative · Oct 7, 2019 · 3a43799 · 3a43799
1 parent 55c2567
commit 3a43799
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/apis/serving/v1/revision_defaults.go b/pkg/apis/serving/v1/revision_defaults.go
@@ -99,7 +99,7 @@ func (rs *RevisionSpec) SetDefaults(ctx context.Context) {
 			}
 
 			if rs.PodSpec.Containers[idx].ReadinessProbe.TimeoutSeconds == 0 {
-				rs.PodSpec.Containers[idx].ReadinessProbe.TimeoutSeconds = 10
+				rs.PodSpec.Containers[idx].ReadinessProbe.TimeoutSeconds = 1
 			}
 		}
 		vms := rs.PodSpec.Containers[idx].VolumeMounts

diff --git a/pkg/apis/serving/v1/revision_defaults_test.go b/pkg/apis/serving/v1/revision_defaults_test.go
@@ -362,7 +362,7 @@ func TestRevisionDefaulting(t *testing.T) {
 							SuccessThreshold: 1,
 							PeriodSeconds:    10,
 							FailureThreshold: 4,
-							TimeoutSeconds:   10,
+							TimeoutSeconds:   1,
 							Handler: corev1.Handler{
 								TCPSocket: &corev1.TCPSocketAction{},
 							},