-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping 'github.com/google/go-containerregistry' dependency #13701
Conversation
Welcome @Bisht13! It looks like this is your first PR to knative/serving 🎉 |
Hi @Bisht13. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
|
So should we ignore the test for now or should I make another PR to delete it? |
I would delete the test in this PR so the change is atomic. |
/retest |
Codecov ReportBase: 86.23% // Head: 86.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13701 +/- ##
==========================================
- Coverage 86.23% 86.19% -0.05%
==========================================
Files 197 197
Lines 14774 14774
==========================================
- Hits 12740 12734 -6
- Misses 1732 1737 +5
- Partials 302 303 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Made the required changes ✨ |
/lgtm thanks @Bisht13 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bisht13, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #10575
Proposed Changes
github.com/google/go-containerregistry
dependency along with its indirect dependenciesExpected Output
Having a default ServiceAccount in a namespace referencing an imagePullSecrets that doesn't exist anymore in the namespace now gives the following output,
Release Note