Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping 'github.com/google/go-containerregistry' dependency #13701

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Bisht13
Copy link
Contributor

@Bisht13 Bisht13 commented Feb 14, 2023

Fixes #10575

Proposed Changes

  • Bumped github.com/google/go-containerregistry dependency along with its indirect dependencies

Expected Output

Having a default ServiceAccount in a namespace referencing an imagePullSecrets that doesn't exist anymore in the namespace now gives the following output,

Creating service 'helloworld-go' in namespace 'default':

  0.574s The Route is still working to reflect the latest desired specification.
  0.652s ...
  2.710s Configuration "helloworld-go" is waiting for a Revision to become ready.
 37.940s ...
 38.383s Ingress has not yet been reconciled.
 38.777s Waiting for load balancer to be ready
 39.027s Ready to serve.

Service 'helloworld-go' created to latest revision 'helloworld-go-00001' is available at URL:

Release Note

imagePullSecrets with references to unknown service accounts won't error out anymore but fail silently like Kubernetes.

@knative-prow
Copy link

knative-prow bot commented Feb 14, 2023

Welcome @Bisht13! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 14, 2023

Hi @Bisht13. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2023
@psschwei
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2023
@dprotaso
Copy link
Member

TestResolveNoAccess test will need to be deleted - it asserted an error occurred if the service account couldn't be found

@Bisht13
Copy link
Contributor Author

Bisht13 commented Feb 14, 2023

TestResolveNoAccess test will need to be deleted - it asserted an error occurred if the service account couldn't be found

So should we ignore the test for now or should I make another PR to delete it?

@dprotaso
Copy link
Member

I would delete the test in this PR so the change is atomic.

@knative-prow knative-prow bot added the area/API API objects and controllers label Feb 14, 2023
@Bisht13
Copy link
Contributor Author

Bisht13 commented Feb 14, 2023

/retest

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 86.23% // Head: 86.19% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (786ad40) compared to base (e2add5d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13701      +/-   ##
==========================================
- Coverage   86.23%   86.19%   -0.05%     
==========================================
  Files         197      197              
  Lines       14774    14774              
==========================================
- Hits        12740    12734       -6     
- Misses       1732     1737       +5     
- Partials      302      303       +1     
Impacted Files Coverage Δ
pkg/reconciler/revision/resolve.go 77.50% <0.00%> (-7.50%) ⬇️
pkg/autoscaler/statserver/server.go 75.91% <0.00%> (-2.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bisht13
Copy link
Contributor Author

Bisht13 commented Feb 14, 2023

I would delete the test in this PR so the change is atomic.

Made the required changes ✨

@dprotaso
Copy link
Member

/lgtm
/approve

thanks @Bisht13

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bisht13, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@knative-prow knative-prow bot merged commit d68797e into knative:main Feb 14, 2023
@Bisht13 Bisht13 deleted the bump-dep branch February 14, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevisionFailed when ServiceAccount references a non-existing imagePullSecret
3 participants