Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "change mininum TLS version for tag to digest resolution (#13886)" #13956

Closed
wants to merge 1 commit into from

Conversation

kahirokunn
Copy link

@kahirokunn kahirokunn commented May 8, 2023

This reverts commit 171cecd.

Fixes #13937

Proposed Changes

  • Supports TLS1.2 to support quay.io etc.

Release Note

Revert "change mininum TLS version for tag to digest resolution (#13886)"

@knative-prow knative-prow bot added the area/API API objects and controllers label May 8, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2023
@knative-prow
Copy link

knative-prow bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ea2a6c8) 86.25% compared to head (b6fe119) 86.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13956   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files         199      199           
  Lines       14749    14749           
=======================================
  Hits        12722    12722           
- Misses       1726     1727    +1     
+ Partials      301      300    -1     
Impacted Files Coverage Δ
pkg/reconciler/revision/resolve.go 77.50% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nak3
Copy link
Contributor

nak3 commented May 8, 2023

/lgtm
/hold
/assign @dprotaso @izabelacg

Could you change the subject of this PR to make it more clear? I think it is okay to use the commit message Revert "change mininum TLS version for tag to digest resolution.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@kahirokunn kahirokunn changed the title Support TLS 1.2 Revert "change mininum TLS version for tag to digest resolution (#13886)" May 8, 2023
@kahirokunn
Copy link
Author

@nak3 done. how about now?

@nak3
Copy link
Contributor

nak3 commented May 8, 2023

Thank you! I am good to merge this. Let's wait for other reviewers in the Europe/US time.

@dprotaso
Copy link
Member

dprotaso commented May 8, 2023

I'm going to close htis PR since I'm making this property configurable via an env var in this PR - #13962

I also reverted the default back to 1.2.

@dprotaso dprotaso closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.10.0 tls: server selected unsupported protocol version 303.
4 participants