Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop safe to evict annotations #14035

Merged
merged 1 commit into from
May 31, 2023
Merged

drop safe to evict annotations #14035

merged 1 commit into from
May 31, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 30, 2023 •
edited
Loading

Fixes #13984

Proposed Changes

  • Drop cluster-autoscaler.kubernetes.io/safe-to-evict annotations on our control plane deployments to allow nodes to drain

Release Note

Drop `cluster-autoscaler.kubernetes.io/safe-to-evict` annotations on our control plane to allow nodes to drain

@dprotaso
drop safe to evict annotations
2d19de7 
this prevents nodes from draining
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 30, 2023
@knative-prow knative-prow bot requested review from jsanin-vmw and kauana May 30, 2023 19:40
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
ReToCode
ReToCode approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@knative-prow
Copy link

knative-prow bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit 3c23945 into knative:main May 31, 2023
@dprotaso dprotaso deleted the drop-safe-to-evict branch June 1, 2023 00:17
@dprotaso
Copy link
Member Author

dprotaso commented Jun 1, 2023

/cherry-pick release-1.10
/cherry-pick release-1.9

@knative-prow-robot knative-prow-robot mentioned this pull request Jun 1, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #14051

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

dprotaso commented Jun 1, 2023

/cherry-pick release-1.9

@knative-prow-robot knative-prow-robot mentioned this pull request Jun 1, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #14054

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

@kauana kauana Awaiting requested review from kauana

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cluster-autoscaler.kubernetes.io/safe-to-evict: "false" annotation prevents GKE nodepool to scale down
3 participants
@dprotaso @ReToCode @knative-prow-robot