Separate Activator SA #14133
Merged
Separate Activator SA #14133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #14133 +/- ##
=======================================
Coverage 86.23% 86.24%
=======================================
Files 199 199
Lines 14795 14798 +3
=======================================
+ Hits 12759 12762 +3
Misses 1734 1734
Partials 302 302 ☔ View full report in Codecov by Sentry. |
|
/retest |
nak3
reviewed
Jun 29, 2023
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
|
/lgtm |
skonto
reviewed
Jul 3, 2023
config/core/200-roles/activator.yaml
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Copyright 2019 The Knative Authors | |||
|
@davidhadas gentle ping. @dprotaso if you have no objection I can merge. |
|
/approve |
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidhadas, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/lgtm |
knative-prow
bot
removed
the
do-not-merge/hold
skonto
pushed a commit
to skonto/serving
that referenced
this pull request
Oct 5, 2023
* Activator SA * Activator SA * Update config/core/200-roles/activator.yaml Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * s/2019/2023 --------- Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce privileges to Activator
See #13857