-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated] Update net-gateway-api nightly #14531
[Automated] Update net-gateway-api nightly #14531
Conversation
ed3cb16
to
5c0c047
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14531 +/- ##
==========================================
- Coverage 86.01% 85.98% -0.04%
==========================================
Files 197 197
Lines 14915 14915
==========================================
- Hits 12829 12824 -5
- Misses 1776 1779 +3
- Partials 310 312 +2 ☔ View full report in Codecov by Sentry. |
ecd95d2
to
e296c0c
Compare
/hold nightly build failed so a file is missing |
@gabo1208 mind to take a look. It might be that this is related to your changes https://github.com/knative-extensions/net-gateway-api/commits?author=gabo1208 |
The failed curl command is working now as below so I guess
|
I can manually add the file or should we wait for the next nightly build?? |
bumping knative.dev/net-gateway-api 33eb24c...a198125: > a198125 Wait for deploy/gateway-api-admission-server to make sure webhook is ready (# 573) > 0e28e43 added gateway api crds file to the release from the third party folder (# 571) > 4089d16 Re-enable random cluster suffix (# 572) > 2067a63 Bump Istio to 1.19.3 (# 568) > ab71c8a upgrade to latest dependencies (# 569) > 0a41f16 removed duplicated section from docs (# 564) > 7509cfa Update community files (# 565) > 7f17c8e upgrade to latest dependencies (# 567) > c8b30f0 Remove api gateway crds (# 557) > bd2d261 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (# 563) Signed-off-by: Knative Automation <automation@knative.team>
e296c0c
to
86711a8
Compare
/lgtm It seems that today's push updated |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-automation, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @knative/serving-writers
/cc @knative/serving-writers
Produced via:
Details: