-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /tmp and /var/log from reserved paths (#14686) #14719
Conversation
Welcome @jacksgt! It looks like this is your first PR to knative/serving 🎉 |
Hi @jacksgt. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
Hey thanks for the PR - you'll want to update the tests |
Signed-off-by: Jack Henschel <jackdev@mailbox.org>
5643a68
to
01a70b2
Compare
@dprotaso Thanks for the hint, I adjusted the tests. CI passed now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14719 +/- ##
==========================================
- Coverage 86.08% 86.00% -0.08%
==========================================
Files 197 197
Lines 14937 14950 +13
==========================================
Hits 12858 12858
- Misses 1770 1780 +10
- Partials 309 312 +3 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, jacksgt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #14686
Proposed Changes
As discussed in #14686, the runtime contract REQUIRES
/tmp
to be a read-writeable folder and/var/log
MAY BE writeable.Since this can be achieved with many different means users should be able to mount volumes at these locations (e.g.
/tmp
for sharing data between containers,/var/log
for shipping logs with a sidecar etc.)https://github.com/knative/specs/blob/a8e7926c041baa58366f4939df9f3fdc866dbbb5/specs/serving/runtime-contract.md#default-filesystems
Release Note