Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set AppProtocol on Services (#14757)" #14805

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Jan 17, 2024

This reverts commit e5602d7.

relates to #14569

Proposed Changes

Release Note


@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers labels Jan 17, 2024
@knative-prow knative-prow bot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jan 17, 2024
@dprotaso
Copy link
Member

/test gateway-api-latest

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d96dabb) 86.05% compared to head (c4b51b6) 85.87%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/queue/sharedmain/handlers.go 0.00% 12 Missing ⚠️
pkg/activator/handler/context.go 60.00% 3 Missing and 1 partial ⚠️
pkg/activator/handler/handler.go 66.66% 2 Missing and 1 partial ⚠️
cmd/activator/main.go 0.00% 2 Missing ⚠️
pkg/http/handler/timeout.go 0.00% 2 Missing ⚠️
pkg/http/response_recorder.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14805      +/-   ##
==========================================
- Coverage   86.05%   85.87%   -0.19%     
==========================================
  Files         197      197              
  Lines       14950    14986      +36     
==========================================
+ Hits        12865    12869       +4     
- Misses       1774     1801      +27     
- Partials      311      316       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

PASS test/conformance/runtime.TestProtocols/h2c

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link

knative-prow bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@KauzClay
Copy link
Contributor Author

/test gateway-api-latest

@knative-prow knative-prow bot merged commit ad0a989 into knative:main Jan 17, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants