Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] fix: Fixed liveness periodseconds to 10 so that crashloopback off doe… #15257

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #15256

Adjust liveness probe to account for stale leases - otherwise webhook would crashloop forever

…sn't happen which causesexpired lease to get stuck.
@knative-prow knative-prow bot requested review from izabelacg and ReToCode May 27, 2024 17:34
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link

knative-prow bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@knative-prow knative-prow bot merged commit 44e9df6 into knative:release-1.14 May 27, 2024
55 checks passed
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request May 29, 2024
* fix cluster-local routes being stalled when external-domain-tls is enabled (knative#15243)

Co-authored-by: dprotaso <dprotaso@gmail.com>

* add pod anti affinity rules to activator component (knative#15244)

Co-authored-by: Izabela Gomes <igomes@vmware.com>

* fix: Fixed liveness periodseconds to 10 so that crashloopback off doesn't happen which causesexpired lease to get stuck. (knative#15257)

Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>

* Drop the k8s service name from kubectl get revision output (knative#15262)

Co-authored-by: dprotaso <dprotaso@gmail.com>

* Sync upstream release

---------

Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: dprotaso <dprotaso@gmail.com>
Co-authored-by: Izabela Gomes <igomes@vmware.com>
Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>
Co-authored-by: John Doe <johndoe@localhost>
Co-authored-by: ReToCode <ReToCode@users.noreply.github.com>
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jun 3, 2024
* fix cluster-local routes being stalled when external-domain-tls is enabled (knative#15243)

Co-authored-by: dprotaso <dprotaso@gmail.com>

* add pod anti affinity rules to activator component (knative#15244)

Co-authored-by: Izabela Gomes <igomes@vmware.com>

* fix: Fixed liveness periodseconds to 10 so that crashloopback off doesn't happen which causesexpired lease to get stuck. (knative#15257)

Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>

* Drop the k8s service name from kubectl get revision output (knative#15262)

Co-authored-by: dprotaso <dprotaso@gmail.com>

---------

Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: dprotaso <dprotaso@gmail.com>
Co-authored-by: Izabela Gomes <igomes@vmware.com>
Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>
Co-authored-by: John Doe <johndoe@localhost>
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jul 4, 2024
* fix cluster-local routes being stalled when external-domain-tls is enabled (knative#15243)

Co-authored-by: dprotaso <dprotaso@gmail.com>

* add pod anti affinity rules to activator component (knative#15244)

Co-authored-by: Izabela Gomes <igomes@vmware.com>

* fix: Fixed liveness periodseconds to 10 so that crashloopback off doesn't happen which causesexpired lease to get stuck. (knative#15257)

Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>

* Drop the k8s service name from kubectl get revision output (knative#15262)

Co-authored-by: dprotaso <dprotaso@gmail.com>

---------

Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: dprotaso <dprotaso@gmail.com>
Co-authored-by: Izabela Gomes <igomes@vmware.com>
Co-authored-by: Mukul Garg <37508311+mukulgit123@users.noreply.github.com>
Co-authored-by: John Doe <johndoe@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants