[release-1.15] Fix bug in cert manager config #15437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #15437 +/- ##
=============================================
Coverage 84.54% 84.54%
=============================================
Files 219 219
Lines 13595 13595
=============================================
Hits 11494 11494
- Misses 1734 1735 +1
+ Partials 367 366 -1 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
openshift-merge-bot bot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Aug 5, 2024
* Use a different 'static' image that supports s390x and ppc (knative#15409) Updated image is recommended by Chainguard Details here: https://www.chainguard.dev/unchained/changes-to-static-git-and-busybox-developer-images-2 Co-authored-by: dprotaso <dprotaso@gmail.com> * clean up (knative#15418) Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com> * clean up old certificate leases (knative#15424) Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com> * [release-1.15] Fix bug in cert manager config (knative#15437) * add test to cover cert manager config edge case * fix edge case bug in cert manager config --------- Co-authored-by: Marius Stein <mariusstein7@gmail.com> --------- Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team> Co-authored-by: dprotaso <dprotaso@gmail.com> Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com> Co-authored-by: Marius Stein <mariusstein7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #15434