Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid helloworld example #4780

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Fix invalid helloworld example #4780

merged 1 commit into from
Sep 29, 2019

Commits on Jul 17, 2019

  1. Fix invalid helloworld example 

    This patch makes a tiny fix which removes invalid setting in
configuration example.

After knative#4731, `periodSeconds`
needs to be set with `failureThreshold` and `timeoutSeconds`. This
patch simply removes `periodSeconds` from the config.
    @nak3
    nak3 committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c0da733 View commit details
    Browse the repository at this point in the history