Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ringing room preview version bump #224

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

centreboard
Copy link
Collaborator

Updates Setup.py to be able to create a preview release for updated RingingRoom.

Drops support for Python 3.6

@centreboard
Copy link
Collaborator Author

@kneasle Could you please edit the status checks to remove python 3.6 and 3.9 and add 3.8 and 3.11 instead?
image

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule

@kneasle
Copy link
Owner

kneasle commented Aug 15, 2023

@kneasle Could you please edit the status checks to remove python 3.6 and 3.9 and add 3.8 and 3.11 instead?

Ohhhh, that's where the required checks were coming from! I forgot I'd set them up, and thought GitHub just had an out-of-date cache somewhere.

You can merge this PR when it's ready, right? I guess it's merge-able as-is but I don't want to merge it and then find out that it was unfinished.

@centreboard centreboard merged commit cce4435 into master Aug 16, 2023
5 checks passed
@centreboard centreboard deleted the ringing_room_preview_version_bump branch August 16, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants