fix build with gcc-15

[heitbaum]

Fixes void declarations

In file included from ./libfaad/output.c:31:
./libfaad/common.h:244:18: error: conflicting types for 'index'; have 'char *(void)'
  244 | #  define strchr index
      |                  ^~~~~
./libfaad/common.h:247:7: note: in expansion of macro 'strchr'
  247 | char *strchr(), *strrchr();
      |       ^~~~~~
In file included from /usr/include/string.h:462,
                 from ./libfaad/common.h:205:
/usr/include/strings.h:68:14: note: previous declaration of 'index' with type 'char *(const char *, int)'
   68 | extern char *index (const char *__s, int __c)
      |              ^~~~~
./libfaad/common.h:245:19: error: conflicting types for 'rindex'; have 'char *(void)'
  245 | #  define strrchr rindex
      |                   ^~~~~~
./libfaad/libfaad/common.h:247:18: note: in expansion of macro 'strrchr'
  247 | char *strchr(), *strrchr();
      |                  ^~~~~~~
/usr/include/strings.h:96:14: note: previous declaration of 'rindex' with type 'char *(const char *, int)'
   96 | extern char *rindex (const char *__s, int __c)
      |              ^~~~~~

[fabiangreffrath]

These declarations are only compiled if building without STDC_HEADERS, which is unconditionally enabled in the build systems. How do you compile faad2?

[heitbaum]

These declarations are only compiled if building without STDC_HEADERS, which is unconditionally enabled in the build systems. How do you compile faad2?

Found where the issue was - I have tested with the external 2.11.1 successfully - closing PR.

Thanks for pointing in the right direction.

[fabiangreffrath]

Thanks for pointing in the right direction.

Thanks for pointing me! I have just removed the offending macro from the code base.