Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 linux wheel #18

Closed
wants to merge 1 commit into from
Closed

Add aarch64 linux wheel #18

wants to merge 1 commit into from

Conversation

davnn
Copy link
Contributor

@davnn davnn commented Oct 10, 2022

As mentioned in #17, this pull request adds an arm64 build to the CI pipeline. Appears to work beautifully :)

@kno10
Copy link
Owner

kno10 commented Oct 14, 2022

Did not work for me on Github. Unfortunately, I only got an entirely useless error message; but this could be due to some temporary failure

 + /opt/python/cp310-cp310/bin/maturin build -i /opt/python/cp310-cp310/bin/python --release --strip
💥 maturin failed
  Caused by: Cargo metadata failed. Does your crate compile with `cargo build`?
  Caused by: `cargo metadata` exited with an error:     Updating crates.io index
Error: Process completed with exit code 1.

@davnn
Copy link
Contributor Author

davnn commented Oct 14, 2022

Interesting, the same pipeline worked for me, see [1] and [2], but, as you said, it might be a temporary failure.

[1] https://pypi.org/project/kmedoids-debug/#files
[2] https://github.com/davnn/python-kmedoids/actions/runs/3220650061

@kno10
Copy link
Owner

kno10 commented Oct 15, 2022

It may be an OOM issue with cargo update, judging from the exit code.
Maybe you have a higher memory limit than me for github actions in your pro account?

+ cargo build --release --verbose
    Updating crates.io index
.github/workflows/build-wheels.sh: line 10:   150 Killed                  cargo build --release --verbose
Error: Process completed with exit code 137.

Adding an unreasonably low "ulimit -v 6000" causes the same error code on native amd64. OTOH, there appear to be 6+GB available, and I can run cargo update here with 1 GB ulimit.

@kno10
Copy link
Owner

kno10 commented Oct 15, 2022

This appears to be cargo#10583, although that does not explain why it worked for you.

@kno10
Copy link
Owner

kno10 commented Oct 15, 2022

It seems to work now, but it takes 60 minutes with qemu to build, and somehow github actions were stuck for quite some time after cleanup of the container.
Anyway, aarch64 packages appear to be available now (no version number change) on https://pypi.org/project/kmedoids/#files

This maturin-action seems to already automate this for more platforms: https://github.com/messense/maturin-action
and maybe we can use this in the future.

@kno10 kno10 closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants