-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: IE8/IE9 cannot use <template id="my-template">
instead of <script id="my-template">
#1783
Comments
Implementation note: This should be as simple as adding |
…ip while binding This fixes knockout#1783
I've tested your suggestion and it looks like that's all that must be done. I've forked Hope this helps, though I'm unsure if I applied the right process for contributing a fix since this is my first submission ever. |
<template id="my-template">
instead of <script id="my-template">
<template id="my-template">
instead of <script id="my-template">
<template id="my-template">
instead of <script id="my-template">
<template id="my-template">
instead of <script id="my-template">
I've added a pull request for the fix: https://github.com/knockout/knockout/pull/1785/files |
Fixed. |
Wrapping templates in
<template>
-tags instead of<script type="text/html">
-tags does not work in Internet Explorer 8 and 9.Supporting IE 8 and 9 in your knockout project forces you to use
<script>
-tags to wrap your templates. Using<template>
-tags leads to these templates being evaluated at page load rather than when the template is being instantiated at run-time - which ofc leads to the bindings within the template failing because in most cases there will not yet be data/the objects being used available.The text was updated successfully, but these errors were encountered: