Adding #ifndef blocks around commonly modified values #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defines to allow these values to be overridden without changing the source code through -D options when compiling. Signed-off-by: Ian Johnson <person.uwsome@gmail.com>
|
Hi, thanks for the contribution. There is already an identical pullrequest from a couple days ago waiting for me to deal with. So, going to close your one but not because we don't want to do this change, just that #119 got there first. |
|
Ah I didn't even see that one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PubSubClient.h : adding #ifndef blocks around the commonly modified #defines to allow the values to be overridden by -D options when compiling. This allows the values to changed without modifying the library source files.