Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bitstamp] include txid in toString() #4896

Merged

Conversation

tross-nydig
Copy link
Contributor

@bigscoop
Copy link
Contributor

bigscoop commented Jun 5, 2024

Hi. Please use @ToString from lombok and delete the method toString()

@tross-nydig
Copy link
Contributor Author

tross-nydig commented Jun 5, 2024

Hi. Please use @ToString from lombok and delete the method toString()

Great idea, the previous toString() also included the additional derived status enum (i.e. status=finished) but I was able to keep it in there by using the @ToString.Include annotation.

@timmolter timmolter merged commit b55715a into knowm:develop Jun 6, 2024
1 check passed
@tross-nydig tross-nydig deleted the tross-nydig/PR/IncludeTxIdInToString branch June 6, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants