Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

166 Integrate VC Data Model Spec Test Suite #167

Merged
merged 46 commits into from
Nov 28, 2023
Merged

166 Integrate VC Data Model Spec Test Suite #167

merged 46 commits into from
Nov 28, 2023

Conversation

LuisOsta
Copy link
Contributor

@LuisOsta LuisOsta commented Nov 22, 2023 •
edited
Loading

  1. Refactored Credential, Presentation & VerifiablePresentation structs in SSI to support full flexibility required by the VC Data Model
  2. Integrated vc test suite spec tests and added it as a GH Action on every PR

@LuisOsta LuisOsta linked an issue Nov 22, 2023 that may be closed by this pull request
Integrate VC Data Model Spec Test Suite Into SSI #166
Closed
@LuisOsta LuisOsta changed the title 166 integrate vc data model spec test suite into ssi 166 Integrate VC Data Model Spec Test Suite Nov 22, 2023
@LuisOsta LuisOsta self-assigned this Nov 27, 2023
@LuisOsta
Copy link
Contributor Author

@fkim7 @adewaleafolabi I'll be merging this with the w3c/vc-test-suite#135 issue still pending as this lays all of the foundations for any future work we may need to do. Our repo has had all of the changes necessary to the inputs that would fix the proof-related issues. If it turns out the upstream is the one with the issue then we'll make a PR, fix it in the upstream and then migrate our usage here from ours to the upstream

@LuisOsta LuisOsta marked this pull request as ready for review November 27, 2023 22:18
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/proof.rs Outdated Show resolved Hide resolved
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/proof.rs Outdated Show resolved Hide resolved
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/proof.rs Outdated Show resolved Hide resolved
@LuisOsta LuisOsta requested a review from gshuflin November 27, 2023 23:27
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
cli/src/main.rs Outdated Show resolved Hide resolved
@LuisOsta LuisOsta requested a review from gshuflin November 27, 2023 23:31
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/credential.rs Outdated Show resolved Hide resolved
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/credential.rs Outdated Show resolved Hide resolved
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/credential.rs Outdated Show resolved Hide resolved
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/credential.rs Outdated Show resolved Hide resolved
gshuflin
gshuflin reviewed Nov 27, 2023
View reviewed changes
core/src/credential.rs Outdated Show resolved Hide resolved
@LuisOsta LuisOsta requested a review from gshuflin November 27, 2023 23:36
@LuisOsta LuisOsta added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 4a4b73a Nov 28, 2023
6 checks passed
@LuisOsta LuisOsta deleted the 166-integrate-vc-data-model-spec-test-suite-into-ssi branch November 28, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkim7 fkim7 fkim7 left review comments

@gshuflin gshuflin gshuflin approved these changes

@adewaleafolabi adewaleafolabi Awaiting requested review from adewaleafolabi

Assignees

@LuisOsta LuisOsta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate VC Data Model Spec Test Suite Into SSI
3 participants
@LuisOsta @gshuflin @fkim7