Fix tagFilters implementation, adding tagFilters with OR relations #117
+164
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tagFilters implementation does not support OR relations, and it has implementation errors which should throw errors, but luckily dart/flutter does not throw (yet). This PR fixes both.
The bug fixed: _paramters['tagFilters'] is created as a List<List> and is cast to a List. Interestingly, this does not throw currently, but I guess there is no guarantee it will not throw one day.
The Feature added: Allow for a combination of AND and OR Tag filters such as:
tag1 AND (tag2 OR tag3) AND (tag4 OR tag5) AND tag6
this is created by defining tagFilters like this:
would love to see this merged, thanks :)
happy if somebody wants to add some docs above but didn't take the time as most other functions do not have serious docs anyway