-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to configure default http_client #151
Conversation
Lint errors were found. A patch is also available. Please see the report: https://flintci.io/repositories/4653/analyses/14464 This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors were found. A patch is also available. Please see the report: https://flintci.io/repositories/4653/analyses/14466 This comment was posted by FlintCI. It can be disabled in the repository settings. |
# Conflicts: # tests/app/TestKernel.php
} | ||
|
||
return parent::getLogDir(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this fixes some deprecation? Can you explain a bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not deprecation fix, but just fix. With latest vendors after running test suite I got cache and logs dir not in their places. After some investigation I found that there were changes Symfony HttpKernel and we need tune this place
# Conflicts: # src/DependencyInjection/Configuration.php
\KnpU\OAuth2ClientBundle\tests\FunctionalTest::testServicesAreUsable covers situation when you trying to use both options in configuration |
Thank you @sadikoff! |
Added to config new options
Fixed some bugs
%s
inInvalidConfigurationException
message