Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to configure default http_client #151

Merged
merged 11 commits into from
Dec 31, 2018
Merged

added ability to configure default http_client #151

merged 11 commits into from
Dec 31, 2018

Conversation

sadikoff
Copy link
Member

@sadikoff sadikoff commented Dec 14, 2018

Added to config new options

http_client_options:
    timeout: '30' # seconds 
    proxy: 'proxy_url' # proxy url string
    verify: true|false # verify or not ssl certificate

Fixed some bugs

  • symfony 4.2 config deprecation
  • wrong cache & log dirs in tests
  • missed %s in InvalidConfigurationException message

@FlintCIBot
Copy link

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/4653/analyses/14464

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/4653/analyses/14466

This comment was posted by FlintCI. It can be disabled in the repository settings.

src/DependencyInjection/KnpUOAuth2ClientExtension.php Outdated Show resolved Hide resolved
}

return parent::getLogDir();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this fixes some deprecation? Can you explain a bit more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not deprecation fix, but just fix. With latest vendors after running test suite I got cache and logs dir not in their places. After some investigation I found that there were changes Symfony HttpKernel and we need tune this place

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@sadikoff
Copy link
Member Author

\KnpU\OAuth2ClientBundle\tests\FunctionalTest::testServicesAreUsable

covers situation when you trying to use both options in configuration

@weaverryan weaverryan merged commit 37311de into master Dec 31, 2018
@weaverryan weaverryan deleted the issue_145 branch December 31, 2018 16:29
@weaverryan
Copy link
Member

Thank you @sadikoff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants