Update TwitchClient configuration #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tpavlek/oauth2-twitch provider returns a [TwitchUser](https://github.com/tpavlek/oauth2-twitch/blob/master/src/Entity/TwitchUser.php) entity.
|
Thanks @chypriote! What's odd is that their TwitchUser is supposed to implement that ResourceOwnerInterface - you can see it in the main library here: https://github.com/thephpleague/oauth2-client/blob/master/src/Provider/AbstractProvider.php#L763 - but to be accurate to how the library actually works, you're totally correct. |
|
Yeah, the current implementation is lacking the ResourceOwnerInterface. I actually started working on an updated fork which both implements the interface and also uses the new Twitch api (helix). Let me know if you wish for me to open a PR for this, as the previous client doesn't seem to be getting any updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tpavlek/oauth2-twitch provider returns a TwitchUser entity.