add symfony 6 return types #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function getContainerExtension() | ||
| public function getContainerExtension(): ?ExtensionInterface |
There was a problem hiding this comment.
ExtensionInterface is a different from that we had in @return KnpUOAuth2ClientExtension - we had incorrect return type? Or if that KnpUOAuth2ClientExtension still relevant, I'd recommend keeping that PHPDoc like this:
@return KnpUOAuth2ClientExtension|ExtensionInterface
There was a problem hiding this comment.
It's minor - but I agree :). But I'm going to merge this
|
Thanks Jesse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.