Twitch helix support #361
Twitch helix support #361
Conversation
|
|
||
| public function getProviderDisplayName() | ||
| { | ||
| return 'Twitch'; |
There was a problem hiding this comment.
Hm, probably Twitch Helix to be different from TwitchProviderConfigurator's name?
README.md
Outdated
| @@ -1407,6 +1408,8 @@ knpu_oauth2_client: | |||
| # will create service: "knpu.oauth2.client.twitch" | |||
| # an instance of: KnpU\OAuth2ClientBundle\Client\Provider\TwitchClient | |||
| # composer require depotwarehouse/oauth2-twitch | |||
| # This is deprecated and won't be supported by Twitch in the near future (Feb. 28 2022) | |||
| # use the twitch_helix one (directly below) if you create a new app | |||
There was a problem hiding this comment.
This is auto-generated section. Please, run bin/update_readme instead to update this correctly.
Also, if the old Twitch way is deprecated, please, update its name in TwitchProviderConfigurator::getProviderDisplayName() to Twitch (deprecated)
|
|
||
| public function getProviderClass(array $config) | ||
| { | ||
| return 'Vertisan\OAuth2\Client\Provider\TwitchHelix'; |
There was a problem hiding this comment.
Can you add use statement for this and below in getClientClass()? Then use TwitchHelix::class.
This is not done this way in most providers, simply because, iirc, they predate PHP 5.5 when this was added :)
…e into twitch-helix
|
This one is ready for review, I applied changes and fixed tests here |
There was a problem hiding this comment.
@ErdemUyanik Thank you for starting working on it! This looks good to me now.
If you could give this new Twitch Helix with the latest changes a try - it would be great :)
Added support for the vertisan/oauth2-twitch-helix bundle