Allow installing the new OAuth client 2.x in dependencies #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um... so the tests do pass... but all the runs in the test matrix use some version of 1.x of the library... (you can see it in the |
|
Yeah, I see... I'm trying to install dependencies locally to see if it grab new version - maybe it's just due to the Travis cache |
|
The new version installation is suppressed by the |
|
Now the new versions 2.x were installed on Travis for OAuth client and facebook |
|
Of course!!! Brilliant! And tests still pass! Tagging a new version now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48