Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the router to get the correct path from the connect facebook check route #96

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Use the router to get the correct path from the connect facebook check route #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbf0d6
use the router to get the correct path from the connect facebook chec…
alexander-schranz Mar 29, 2018
5ea18c9
use _route name for supports check in Authenticator Example
alexander-schranz Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ class MyFacebookAuthenticator extends SocialAuthenticator

public function supports(Request $request)
{
// continue ONLY if the URL matches the check URL
return $request->getPathInfo() == '/connect/facebook/check';
// continue ONLY if the current ROUTE matches the check ROUTE
return $request->attributes->get('_route') === 'connect_facebook_check';
}

public function getCredentials(Request $request)
Expand Down