Add hint to call supports in getCredentials method for symfony lower than 3.4 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alexander-schranz! I think it's actually 3.3 and lower that have the issue - 3.4 should act like 4.0. But, I like the idea - we just need to tweak the message. |
|
@weaverryan updated the message to lower than 3.4 and fix the supports function call. |
alexander-schranz
changed the title
|
It looks good to me 👍 |
README.md
Outdated
| @@ -273,6 +273,11 @@ class MyFacebookAuthenticator extends SocialAuthenticator | |||
| { | |||
| // this method is only called if supports() returns true | |||
|
|
|||
| // For Symfony lower than 3.4 the supports method need to be called manually here: | |||
| // if (!$this->supports($request)) { | |||
| // return; | |||
There was a problem hiding this comment.
Let's explicitly return null here since this method is supposed to return something, but just return; is supposed to return void
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #79 the docs is not longer working for lower than symfony 3.4. So a hint should be added how to get it work with <3.4