Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement o200k_base encoding and support gpt-4o #99

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

chatanywhere
Copy link
Contributor

Implement o200k_base encoding and support gpt-4o

@chatanywhere chatanywhere requested a review from tox-p as a code owner May 27, 2024 12:06
@fernando-arellano
Copy link

Hello @tox-p thanks for all the support on maintaining this repo. Is there anything we can do to help you with this PR? we're relying on this library in our project and righ now we're looking to start using gpt4o but it seems the library doesn't have support yet for gpt4 o. please let us know if there is something we can do to help with this.

@jcrupi
Copy link

jcrupi commented Jun 11, 2024

Checking in on this approval

@mkemmerz
Copy link

@tox-p Sorry to annoy you directly but any plan to review this PR?

@keyurgolani7878
Copy link

Hey, @tox-p Can you provide update on when are you planning to review the PR? I need gpt-4o encoding ASAP. Thanks!

@Grogdunn
Copy link

meanwhile 🤐

<dependency>
    <groupId>net.optionfactory</groupId>
    <artifactId>jtokkit</artifactId>
    <version>1.1.1</version>
</dependency>

@keyurgolani7878
Copy link

meanwhile 🤐

<dependency>
    <groupId>net.optionfactory</groupId>
    <artifactId>jtokkit</artifactId>
    <version>1.1.1</version>
</dependency>

meanwhile 🤐

<dependency>
    <groupId>net.optionfactory</groupId>
    <artifactId>jtokkit</artifactId>
    <version>1.1.1</version>
</dependency>

I can't find this on maven central. Can you help me?

@Grogdunn
Copy link

meanwhile 🤐

<dependency>
    <groupId>net.optionfactory</groupId>
    <artifactId>jtokkit</artifactId>
    <version>1.1.1</version>
</dependency>

I can't find this on maven central. Can you help me?

Strange, I've released this morning and I see in central portal: https://central.sonatype.com/artifact/net.optionfactory/jtokkit

@mkemmerz
Copy link

meanwhile 🤐

<dependency>
    <groupId>net.optionfactory</groupId>
    <artifactId>jtokkit</artifactId>
    <version>1.1.1</version>
</dependency>

I can't find this on maven central. Can you help me?

Strange, I've released this morning and I see in central portal: https://central.sonatype.com/artifact/net.optionfactory/jtokkit

Not sure what dependency that is but not the one from this Github repo, this is the correct maven repo: https://mvnrepository.com/artifact/com.knuddels/jtokkit

@Grogdunn
Copy link

@mkemmerz of course that dependency has different groupId. It came from a fork with merged support for GPT-4o and GPT-4-turbo models. Nothing "strange", I've need of this functionality for some customers, so I've published myself. Here the fork https://github.com/optionfactory/jtokkit and thanks for the peole who made the PR.

@joesh36
Copy link

joesh36 commented Jun 27, 2024

Any progress made to merge it to the main repo?

@joesh36
Copy link

joesh36 commented Jul 15, 2024

Hey, @tox-p there is a plan to review this PR soon? we really need this encoding.
Thanks

@Plexcalibur Plexcalibur merged commit 85c1ae4 into knuddelsgmbh:main Jul 18, 2024
1 of 2 checks passed
@mkemmerz
Copy link

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants