Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make RTT buffer size configurable #628

Closed
japaric opened this issue Nov 22, 2021 · 1 comment
Closed

make RTT buffer size configurable #628

japaric opened this issue Nov 22, 2021 · 1 comment
Assignees
@spookyvision
Labels
type: enhancement Enhancement or feature request

Comments

@japaric
Copy link
Member

japaric commented Nov 22, 2021

currently it's fixed to 1 KiB.

coming up with a configuration mechanism is part of this issue. One option is use an env variable, e.g. DEFMT_RTT_BUFFER_SIZE.

as a size power of 2 improves performance it would be good to inform that to user where configuring the size of this buffer
@japaric japaric added the type: enhancement Enhancement or feature request label Nov 22, 2021
@japaric
Copy link
Member Author

japaric commented Nov 22, 2021

tentatively assigning @spookyvision -- please un-assign yourself if you can't actively work on this

bors bot added a commit that referenced this issue Nov 25, 2021
@bors
Merge #633
964c8e7 
633: fix #628 r=jonas-schievink a=spookyvision

open questions:

also make this honor the env var?
```rust
// print/src/main.rs:28
const READ_BUFFER_SIZE: usize = 1024;
```
(answered: no, irrelevant)

---

add some hints in the app template?
(answered: yes)

Co-authored-by: Anatol Ulrich <anatol.ulrich@ferrous-systems.com>
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
@bors bors bot closed this as completed in abbe85b Nov 25, 2021
spookyvision pushed a commit to spookyvision/app-template that referenced this issue Nov 25, 2021
add documentation for knurling-rs/defmt#628
e132d04
@spookyvision spookyvision mentioned this issue Nov 25, 2021
Merged
spookyvision pushed a commit that referenced this issue Nov 25, 2021
mention #628
04d01fe
bors bot added a commit that referenced this issue Nov 25, 2021
@bors
Merge #635
8a6a1c3 
635: mention #628 r=spookyvision a=spookyvision



Co-authored-by: Anatol Ulrich <anatol.ulrich@ferrous-systems.com>
Urhengulas pushed a commit to knurling-rs/app-template that referenced this issue Nov 26, 2021
@spookyvision
Add documentation for knurling-rs/defmt#628 (#58)
d82fad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spookyvision spookyvision

Labels
type: enhancement Enhancement or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spookyvision @japaric