write! macro: remove runtime check #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when this feature was added, it was possible to call `write!` more than once from a `Format::format` implementation. that operation corrupted the data stream so a runtime check was added to `write!` to prevent the data corruption by panicking on a double use of `write!` PR #305 makes `write!` consume the `Formatter` value so the above issue is now prevented at compile time. The runtime check is no longer necessary (failure case is unreachable) so we remove it
jonas-schievink
approved these changes
Dec 16, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when this feature was added, it was possible to call
write!more than once from aFormat::formatimplementation. that operation corrupted the data stream so a runtime check was added to
write!toprevent the data corruption by panicking on a double use of
write!PR #305 makes
write!consume theFormattervalue so the above issue is now prevented at compiletime. The runtime check is no longer necessary (failure case is unreachable) so we remove it