Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive(Format): better encode str fields #312

Merged
merged 3 commits into from
Dec 17, 2020
Merged

derive(Format): better encode str fields #312

merged 3 commits into from
Dec 17, 2020

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 17, 2020

use {:str} instead of {:?}

jonas-schievink
jonas-schievink approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we test decoding of this too?

@japaric
Copy link
Member Author

japaric commented Dec 17, 2020

added a qemu test (I don't think we can test derive in the defmt_decoder unit tests)

@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 17, 2020

Build succeeded:

@bors bors bot merged commit dd4067f into main Dec 17, 2020
@bors bors bot deleted the faster-str branch December 17, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japaric @jonas-schievink