Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: match unused vars if logging is disabled #497

Merged
merged 1 commit into from
May 31, 2021
Merged

macros: match unused vars if logging is disabled #497

merged 1 commit into from
May 31, 2021

Conversation

Urhengulas
Copy link
Member

Fixes #494

@Urhengulas
Copy link
Member Author

Urhengulas commented May 30, 2021 •
edited
Loading

I am a bit unsure how to add a test for this. Running the snapshot tests with --no-default-features would probably work, since it then would emit the unused-vars-warnings which should mismatch the snapshots, but this seems a bit over the top.

jonas-schievink
jonas-schievink reviewed May 31, 2021
View reviewed changes
macros/src/lib.rs Outdated Show resolved Hide resolved
macros/src/lib.rs Outdated Show resolved Hide resolved
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 31, 2021

Build succeeded:

@bors bors bot merged commit 4ca63c0 into main May 31, 2021
@bors bors bot deleted the fix-unused-vars branch May 31, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink Awaiting requested review from jonas-schievink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

semver-breaking: "Unused variable" errors with deny(unused).
2 participants
@Urhengulas @jonas-schievink