-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2/n] - Remove code-size-costly optimizations #507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Panics on reentrant acquire. - Remove `Write` trait.
Dirbaio
force-pushed
the
remove-optimizations
branch
2 times, most recently
from
June 13, 2021 22:41
21aff44
to
af87dd1
Compare
Dirbaio
changed the title
Remove code-size-costly optimizations
[2/n] Remove code-size-costly optimizations
Jun 13, 2021
Dirbaio
changed the title
[2/n] Remove code-size-costly optimizations
[2/n] - Remove code-size-costly optimizations
Jun 13, 2021
Merged
jonas-schievink
suggested changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Dirbaio
force-pushed
the
remove-optimizations
branch
from
June 16, 2021 14:54
af87dd1
to
6aa2be1
Compare
Dirbaio
force-pushed
the
remove-optimizations
branch
from
June 16, 2021 15:06
6aa2be1
to
2b87d4b
Compare
Urhengulas
added
breaking change
fix / feature / improvement involves a breaking change and needs to wait until next minor version
status: blocked
Blocked on another issue, or on upstream libraries
labels
Jun 16, 2021
jonas-schievink
approved these changes
Jun 16, 2021
Urhengulas
removed
the
status: blocked
Blocked on another issue, or on upstream libraries
label
Jun 17, 2021
The same applies for this PR, as for #505 :) |
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
fix / feature / improvement involves a breaking change and needs to wait until next minor version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of N of #492. Depends on #505
Code size comparsion (only including gains from this PR, not #505):